Refactor ens and async_ens to call resolver only if coin_type is specified #3584
+104
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
added a commit
to abhinay/web3.py
that referenced
this pull request
Jan 31, 2025
fselmo
force-pushed
the
refactor-ens-resolver-call
branch
from
2beca7b to
7b14d37
Compare
|
Thanks again. Merged 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Previously, in
ens.pyandasync_ens.py, the methodaddress()always calledself.resolver(name)even whencoin_typewasNone. This meant an unnecessary call in scenarios where the resolver wasn’t actually used.Related to Issue #3582
Closes #3582
How was it fixed?
Moved the
self.resolver(name)call inside theelseblock. Now it’s only triggered ifcoin_typeis notNone. This prevents an extra network call whencoin_typeis absent.Todo:
Cute Animal Picture